BQ sink produces sample of successful inserts #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
woop
approved these changes
Jul 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
pyalex
pushed a commit
to pyalex/feast
that referenced
this pull request
Jul 17, 2020
* feature row batch produces sample * lint Co-authored-by: Willem Pienaar <git@willem.co>
pyalex
pushed a commit
that referenced
this pull request
Jul 17, 2020
* feature row batch produces sample * lint Co-authored-by: Willem Pienaar <git@willem.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Output of BQ batch insert is now sample from all inserted rows.
Which issue(s) this PR fixes:
Currently BQ's
successful insertsproduces all rows that were in batch. In some use-cases like batch ingestion it could produce up to 30k / sec rows (or ~5 M rows in batch for the default flush frequency (3m)). This output is used in metrics where whole batch (with 5M rows) is grouped into single list, which requires it to fit into memory of one machine. This can lead to memory issues.I suspect that this is overkill since metrics can be easily calculated from sample of inserted data instead of whole batch. This PR changes BQ successful inserts to output only sample of inserted data.
Does this PR introduce a user-facing change?: