Add caching to authorization #884
Conversation
jmelinav
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
|
Hi @jmelinav. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jmelinav
force-pushed
the
cache-auth
branch
2 times, most recently
from
8be26e2
to
1d0dbe4
Compare
|
/retest |
|
@jmelinav: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ? |
|
/test java |
jmelinav
changed the title
|
/assign @davidheryanto |
|
/ok-to-test |
|
/test test-end-to-end-auth |
auth/pom.xml
Outdated
| @@ -91,6 +95,17 @@ | |||
| <artifactId>jsr305</artifactId> | |||
| <version>3.0.2</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.springframework</groupId> | |||
There was a problem hiding this comment.
Can we fix the formatting here please?
There was a problem hiding this comment.
Do you guys use any specific formatter? I remember it happened in my last PR too.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmelinav, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* Cache authorization. * fix formatting, removed default key generator and added a bean. * fix rebase errors.
What this PR does / why we need it:
Currently all requests are authorized against an external server, as this can cause latency issues in serving, Caching the authorization for a short span of time will avoid external call on subsequent requests.
Which issue(s) this PR fixes:
related to #823
Does this PR introduce a user-facing change?:No