Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobCoordinator can be configured to use only subset of FeatureSets or Stores #947

Merged
merged 5 commits into from
Aug 14, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Aug 13, 2020

What this PR does / why we need it:
This PR adds ability to configure via application properties which FeatureSets and Stores will be available in (and managed by) current instance of JobManager.

This should be useful when you have several deployments of JobManager and each will be responsible for only subset of FeatureSets.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

# application.yaml
feast:
  jobs:
    coordinator:
      # Specify feature sets that should be handled by current instance of JobManager
      featureSetSelector:
        - project: "*"
          name: "*"
      # Stores names that will be used by current instance of JobManager
      whitelisted-stores: [online, online_cluster, historical]

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 13, 2020

/test test-end-to-end-batch-dataflow
/test test-end-to-end-batch

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 13, 2020

/test test-end-to-end-batch-dataflow

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Aug 14, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@pyalex
Copy link
Collaborator Author

pyalex commented Aug 14, 2020

/test test-end-to-end-redis-cluster

@pyalex pyalex merged this pull request into feast-dev:master Aug 14, 2020
pyalex added a commit to pyalex/feast that referenced this pull request Aug 14, 2020
zhangchi1 pushed a commit to Cimpress-MCP/feast that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants