Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker-compose test #973

Merged
merged 5 commits into from
Sep 2, 2020
Merged

Fix docker-compose test #973

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b55faa
Fix docker-compose test
terryyylim Sep 1, 2020
c092b70
Address PR comments
terryyylim Sep 2, 2020
af6a3d4
Fix docker-compose bash script
terryyylim Sep 2, 2020
4916e8c
Update flag
terryyylim Sep 2, 2020
e0225ac
Update polling interval
terryyylim Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/master_only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,4 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Test docker compose
run: ./infra/scripts/test-docker-compose.sh
run: ./infra/scripts/test-docker-compose.sh ${GITHUB_SHA}
Copy link
Member

@woop woop Sep 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might also be better to move this test to the complete workflow, along with the load test. So that it depends on the images being built.

5 changes: 5 additions & 0 deletions infra/scripts/test-docker-compose.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ export COMPOSE_INTERACTIVE_NO_CLI=1
cd ${PROJECT_ROOT_DIR}/infra/docker-compose/
cp .env.sample .env

# Replace FEAST_VERSION with latest github image SHA
woop marked this conversation as resolved.
Show resolved Hide resolved
tmpfile=$(mktemp /tmp/docker-compose.XXXXXX)
FEAST_VERSION=$(grep FEAST_VERSION .env | cut -d '=' -f 2-)
sed "s|$FEAST_VERSION|$LATEST_GH_COMMIT_SHA|g" < .env > $tmpfile && mv $tmpfile .env

# Start Docker Compose containers
docker-compose up -d

Expand Down