Fix Java & Go SDK TLS support #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzzy
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
pyalex
approved these changes
Sep 7, 2020
|
/lgtm |
|
/retest |
woop
reviewed
Sep 7, 2020
sdk/go/client.go
Outdated
| tlsCreds, err := credentials.NewClientTLSFromFile(security.TLSCertPath, "") | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| options = append(options, grpc.WithTransportCredentials(tlsCreds)) | ||
| } else if security.EnableTLS { |
There was a problem hiding this comment.
Should this maybe be an else? the predicate is redundant.
woop
reviewed
Sep 7, 2020
| // configure client with no security config. | ||
| return FeastClient.createSecure(host, port, SecurityConfig.newBuilder().build()); | ||
| } catch (SSLException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Is there a reason to rethrow without any attached message?
There was a problem hiding this comment.
Updated createSecure() to throw IllegalArgumentException when provided with bad certificate.
- Removed redundant try catch in
create()
|
/hold |
…nto account TLS in naming.
…s not specified in SecurityConfig
…xception instead of SSLException.
woop
approved these changes
Sep 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up of #971:
NewAuthGrpcClient()->NewSecureGrpcClient()createdAuthenticated()->createSecure()Continuation of #504
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: