Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maps in environment variables in helm charts #987

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Sep 8, 2020

What this PR does / why we need it:
Currently it's not possible to use more complicated expressions (than string or int) as environment variable in kubernetes Deployment object via helm charts. Map structure could be useful to provide kube metadata as parameter to feast services.

env:
- name: MY_POD_NAMESPACE
  valueFrom:
    fieldRef:
      fieldPath: metadata.namespace

Now this can be achieved with
--set envOverrides.MY_POD_NAMESPACE.fieldRef.fieldPath=metadata.namespace

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@pyalex
Copy link
Collaborator Author

pyalex commented Sep 8, 2020

/test test-end-to-end-redis-cluster

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit c9eb264 into feast-dev:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants