Survival block breaking

[koskja]

Implementing breaking blocks in survival

Status

• Ready
• Development
• Hold

Description

The goal of this PR is to implement the survival mining mechanic. This depends on potion effects (haste and mining fatigue) and physics (player in water/flying). The blocks currently do not drop items on the ground, nor does mining decrease durability.

I believe that the related issues can be resolved at a later time, simply because mining is an integral part of the game and works well enough without these features.

Related issues

Original issue #351
Potion effects #430
Physics #357

Checklist

• Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
• Removed unnecessary commented out code
• Used specific traces (if you trace actions please specify the cause i.e. the player)

[Defman]

Is this something you want me to look at soon?

[koskja]

This PR actually feels mostly finished. I added a feature that allows the player to change their gamemode by writing 's' or 'c' in the chat, and I am not sure whether we want to keep push that to main. It does howerver seem like a good placeholder before we get actual commands. Other than that, I am happy with the rest and it is up for review.

[Defman]

Looks good, its a bit wide as its also implementing a simple effect api. Hopefully a future API could take this simple api and improve upon it.

The code is quite self explanatory, but could be nice with a few references to the constants and etc.

I noticed the CI is complaining about noun vs no_run.

[koskja]

Anything else?