Icon request: file-check, file-x, folder-check, folder-x

[controversial]

Icon Request

• Icon name: “check” and “x” variants of the file and folder icons
• Use case: There are already file-plus and file-minus icons (and the equivalent for folders) to symbolize adding and removing these objects, but being able to symbolize success and validation in relation to files and folders would be enormously useful for many apps, especially those involving uploads
• Screenshots of similar icons:

(all from unicons)

[jletey]

@colebemis @locness3 @controversial How does this look?

[moeenio]

@colebemis @locness3 @controversial How does this look?

This one looks great, but make sure to be in compliance with #171 .

[jletey]

This one looks great, but make sure to be in compliance with #171 .

Yup ... looking like it is in compliance ... going to submit a PR!

[moeenio]

@johnlestey
No they are not.

[jletey]

No they are not.

@locness3 What is wrong?

[moeenio]

Strokes = Borders. This means you should use borders instead of fills. Also, you shouldn't use the masks provided for Figma when submitting your icons. You should use only svg shapes themselves.

[jletey]

Refactoring now ... will update you to have a look when I'm done!

[jletey]

@locness3 I've updated the icons ... please take a look! They now use SVG shapes instead of components and also I have shrunk the "x" to have the same top and bottom space as the "check"

[moeenio]

@locness3 I've updated the icons ... please take a look! They now use SVG shapes instead of components and also I have shrunk the "x" to have the same top and bottom space as the "check"

Great, but please use a border for the checks and X, instead of a fill. BTW, you should remove the original "file" and "folder" groups from the icons.

[jletey]

@locness3 The checks and Xs now have a 1px border (is that a violation of #171?) and I have removed all icon groups ... solely vectors now!

[moeenio]

a 1px border (is that a violation of #171?)

#171 is again very clear : "Every line and shape has a 2px center-aligned stroke with round joins and round caps"

[jletey]

@locness3 Have changed ... but IMHO, they look ugly now

[jletey]

@locness3 @controversial How does it look now?

[moeenio]

Maybe make the checks and crosses smaller.

[jletey]

@locness3 @ahtohbi4 How does it look now? Figma

[moeenio]

Perfect!