Does not add all needed Feathers dependencies #90

binury · 2017-06-07T18:52:36Z

Note: Please include Node.js version (node -v) and npm version (npm -v) when reporting on this issue.

Steps to reproduce

❯ fgtest feathers g app .
? Project name fgtest
? Description
? What folder should the source files live in? src
? Which package manager are you using (has to be installed globally)? Yarn
? What type of API are you making? (Press <space> to select, <a> to toggle all, <i> to inverse selection)REST, Realtime via Socket.io
   create package.json
   create config/default.json
   create LICENSE
   create public/favicon.ico
   create public/index.html
   create .editorconfig
   create .eslintrc.json
   create .npmignore
   create src/app.hooks.js
   create src/hooks/logger.js
   create src/index.js
   create src/middleware/index.js
   create src/services/index.js
   create .gitignore
   create README.md
   create src/app.js
   create test/app.test.js
   create config/production.json
yarn add v0.24.6
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 200 new dependencies.
❯ fgtest [1m 2s] yarn start
yarn start v0.24.6
$ node src/
module.js:487
    throw err;
    ^

Error: Cannot find module 'winston'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/teddy/code/scratch-projects/fgtest/src/index.js:2:16)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
error Command failed with exit code 1.

❯ fgtest cat package.json
{
  "name": "fgtest",
  "description": "",
  "version": "0.0.0",
  "homepage": "",
  "main": "src",
  "keywords": [
    "feathers"
  ],
  "author": {
    "name": "Bin Ury",
    "email": "bin.ury@tuta.io"
  },
  "contributors": [],
  "bugs": {},
  "directories": {
    "lib": "src"
  },
  "engines": {
    "node": ">= 6.0.0",
    "yarn": ">= 0.18.0"
  },
  "scripts": {
    "test": "npm run eslint && npm run mocha",
    "eslint": "eslint src/. test/. --config .eslintrc.json",
    "start": "node src/",
    "mocha": "mocha test/ --recursive"
  },
  "dependencies": {
    "eslint": "^3.19.0",
    "mocha": "^3.4.2",
    "request": "^2.81.0",
    "request-promise": "^4.2.1"
  }
}

System configuration

❯ fgtest feathers g app .
? Project name fgtest
? Description
? What folder should the source files live in? src
? Which package manager are you using (has to be installed globally)? Yarn
? What type of API are you making? (Press <space> to select, <a> to toggle all, <i> to inverse selection)REST, Realtime via Socket.io

Module versions (especially the part that's not working):
Feathers-cli 2.0.5
yarn 0.24.6
NodeJS version:
8.0.0
Operating System:
MacOS 10.12.6

The text was updated successfully, but these errors were encountered:

binury · 2017-06-07T18:56:52Z

It should be noted that this also occurs sometimes when new services with extra dependencies are generated.

ekryski · 2017-06-07T19:32:08Z

I wonder if updating yeoman-env did something funky?? 1a84cf9

@teddy-error would you be able to quickly test if this works with feathers-cli v2.0.4?

marshallswain · 2017-06-07T20:42:19Z

Maybe this is related to using npm@5. I reported a similar error with the DoneJS generator: donejs/donejs#959 Maybe related to the lock file?

daffl · 2017-06-07T23:44:04Z

I don't think it's the Yeoman environment, that PR hasn't been published yet. I'll re-run the tests for the Generator with Node 8, they should be failing already then.

daffl · 2017-06-08T02:07:44Z

I just installed Node 8 using nvm and can't reproduce the issue. It looks like your package.json got somehow mangled. Is this reproducible for anybody else?

luiz-filipe · 2017-06-09T16:54:12Z

Just to let you know the same happened to me. Created a new app using the feathers-cli and tried to run the tests straight away:

Output

$ npm run test

> shout@0.0.0 test /Users/filipe/Develop/the-vitamin/api
> npm run eslint && npm run mocha


> shout@0.0.0 eslint /Users/filipe/Develop/the-vitamin/api
> eslint src/. test/. --config .eslintrc.json


> shout@0.0.0 mocha /Users/filipe/Develop/the-vitamin/api
> mocha test/ --recursive

module.js:487
    throw err;
    ^

Error: Cannot find module 'serve-favicon'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/filipe/Develop/the-vitamin/api/src/app.js:2:17)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/filipe/Develop/the-vitamin/api/test/app.test.js:3:13)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at /Users/filipe/Develop/the-vitamin/api/node_modules/mocha/lib/mocha.js:230:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/filipe/Develop/the-vitamin/api/node_modules/mocha/lib/mocha.js:227:14)
    at Mocha.run (/Users/filipe/Develop/the-vitamin/api/node_modules/mocha/lib/mocha.js:495:10)
    at Object.<anonymous> (/Users/filipe/Develop/the-vitamin/api/node_modules/mocha/bin/_mocha:469:18)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

Generated package.json

{
  "name": "shout",
  "version": "0.0.0",
  "homepage": "",
  "main": "src",
  "keywords": [
    "feathers"
  ],
  "contributors": [],
  "bugs": {},
  "directories": {
    "lib": "src"
  },
  "engines": {
    "node": ">= 6.0.0",
    "yarn": ">= 0.18.0"
  },
  "scripts": {
    "test": "npm run eslint && npm run mocha",
    "eslint": "eslint src/. test/. --config .eslintrc.json",
    "start": "node src/",
    "mocha": "mocha test/ --recursive"
  },
  "dependencies": {
    "eslint": "^3.19.0",
    "feathers-mongoose": "^5.1.0",
    "mocha": "^3.4.2",
    "mongoose": "^4.10.5",
    "request": "^2.81.0",
    "request-promise": "^4.2.1"
  }
}

Environment

Node: 8.1.0
feathers-cli: 2.0.5
MacOS: 10.12.5
Yarn: 0.23.4

luiz-filipe · 2017-06-09T17:06:11Z

So I uninstalled feathers-cli 2.0.5, installed 2.0.4 and the generated app worked fine, but the mysterious part is that after reinstalling 2.0.5 and regenerating the app with it, it works fine now.

I'm confused.

package.json of the app generated after reinstalling 2.0.5

{
  "name": "temp",
  "description": "",
  "version": "0.0.0",
  "homepage": "",
  "main": "src",
  "keywords": [
    "feathers"
  ],
  "contributors": [],
  "bugs": {},
  "directories": {
    "lib": "src"
  },
  "engines": {
    "node": ">= 6.0.0",
    "yarn": ">= 0.18.0"
  },
  "scripts": {
    "test": "npm run eslint && npm run mocha",
    "eslint": "eslint src/. test/. --config .eslintrc.json",
    "start": "node src/",
    "mocha": "mocha test/ --recursive"
  },
  "dependencies": {
    "body-parser": "^1.17.2",
    "compression": "^1.6.2",
    "cors": "^2.8.3",
    "eslint": "^3.19.0",
    "feathers": "^2.1.3",
    "feathers-configuration": "^0.4.1",
    "feathers-errors": "^2.8.1",
    "feathers-hooks": "^2.0.1",
    "feathers-hooks-common": "^3.5.1",
    "feathers-mongodb": "^2.9.0",
    "feathers-rest": "^1.7.3",
    "helmet": "^3.6.1",
    "mocha": "^3.4.2",
    "mongodb": "^2.2.28",
    "request": "^2.81.0",
    "request-promise": "^4.2.1",
    "serve-favicon": "^2.4.3",
    "winston": "^2.3.1"
  }
}

daffl · 2017-06-09T17:47:52Z

It's still strange because the devDependencies (mocha, eslint) ended up in the normal dependencies which I did notice as well. I suspect it's either something with Node 8 or something that changed with Yeoman.

daffl · 2017-06-10T18:03:26Z

The devDependencies problem has been fixed. If the missing dependencies issue is intermittent I don't think there is too much we can do but we can look into it more if it persists for more people (after reinstalling).

mericano1 · 2017-10-04T14:34:20Z

I am having the same issue with › feathers --version 2.3.7

my package.json does not have any dependencies, only devDependencies. Here is what was generated

  "name": "calendar-brain",
  "description": "it's the thought that counts",
  "version": "0.0.0",
  "homepage": "",
  "main": "src",
  "keywords": [
    "feathers"
  ],
  "author": {
    "name": "asalvadore",
  },
  "contributors": [],
  "bugs": {},
  "directories": {
    "lib": "src",
    "test": "test/"
  },
  "engines": {
    "node": ">= 6.0.0",
    "yarn": ">= 0.18.0"
  },
  "scripts": {
    "test": "npm run eslint && npm run mocha",
    "eslint": "eslint src/. test/. --config .eslintrc.json",
    "start": "node src/",
    "mocha": "mocha test/ --recursive"
  },
  "devDependencies": {
    "eslint": "^4.8.0",
    "mocha": "^4.0.0",
    "request": "^2.83.0",
    "request-promise": "^4.2.2"
  }
}

marshallswain · 2017-10-04T14:37:41Z

Please include Node.js version (node -v) and npm version (npm -v) when reporting on this issue. I'm pretty sure the behavior of this issue is independent of the feathers-cli, itself.

mericano1 · 2017-10-04T14:39:21Z

Sorry, always forget those.

› node -v
v8.6.0
› npm -v
5.4.2

ulfmaier · 2017-10-07T15:47:45Z

Happened to me too. Had only devDependencies and no dependencies.

Deleted the project folder and let it generate again and the dependencies where there as expected. I did not update / reinstall / ... anything before the 2nd try.

Settings used:

feathers generate app
? Project name feathers-app
? Description 
? What folder should the source files live in? src
? Which package manager are you using (has to be installed globally)? Yarn
? What type of API are you making? REST, Realtime via Socket.io

yarn 1.1.0
npm 5.4.2
node v8.6.0
feathers-cli 2.3.7
macOS 10.13

daffl · 2017-10-07T16:34:25Z

If someone can create a reproducible example we can look into it but if it is only intermittent I am not sure there is much we can do.

pepe · 2017-10-09T12:51:58Z

Hello, same for me with the same config as @ulfmaier :

yarn 1.1.0
npm 5.4.2
node v8.6.0
feathers-cli 2.3.7
macOS 10.13

And for me, it is always the case, not only intermittent. I uninstalled node and yarn and installed them back with no luck. Strange thing is, that puppeteer package is installed at the end of the installation. Which I was playing with lately.

But even stranger when I choose npm as installation method, everything works great.

I am afraid it only adds to the confusion, I just wanted to share my experience.

Cengkaruk · 2017-11-08T05:49:38Z

Same with @pepe when i choose npm, everything works well.

daffl mentioned this issue Jun 10, 2017

Test and fix for Yarn saveDev feathersjs-ecosystem/generator-feathers#217

Merged

daffl closed this as completed in feathersjs-ecosystem/generator-feathers#217 Jun 10, 2017

daffl mentioned this issue Feb 8, 2022

Generate app misses dependencies feathersjs/feathers#2551

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Does not add all needed Feathers dependencies #90

Does not add all needed Feathers dependencies #90

binury commented Jun 7, 2017 •

edited by marshallswain

Loading

binury commented Jun 7, 2017 •

edited

Loading

ekryski commented Jun 7, 2017

marshallswain commented Jun 7, 2017 •

edited

Loading

daffl commented Jun 7, 2017

daffl commented Jun 8, 2017

luiz-filipe commented Jun 9, 2017 •

edited

Loading

luiz-filipe commented Jun 9, 2017 •

edited

Loading

daffl commented Jun 9, 2017

daffl commented Jun 10, 2017

mericano1 commented Oct 4, 2017 •

edited

Loading

marshallswain commented Oct 4, 2017

mericano1 commented Oct 4, 2017 •

edited

Loading

ulfmaier commented Oct 7, 2017

daffl commented Oct 7, 2017

pepe commented Oct 9, 2017

Cengkaruk commented Nov 8, 2017

Does not add all needed Feathers dependencies #90

Does not add all needed Feathers dependencies #90

Comments

binury commented Jun 7, 2017 • edited by marshallswain Loading

Steps to reproduce

System configuration

binury commented Jun 7, 2017 • edited Loading

ekryski commented Jun 7, 2017

marshallswain commented Jun 7, 2017 • edited Loading

daffl commented Jun 7, 2017

daffl commented Jun 8, 2017

luiz-filipe commented Jun 9, 2017 • edited Loading

Output

Generated package.json

Environment

luiz-filipe commented Jun 9, 2017 • edited Loading

package.json of the app generated after reinstalling 2.0.5

daffl commented Jun 9, 2017

daffl commented Jun 10, 2017

mericano1 commented Oct 4, 2017 • edited Loading

marshallswain commented Oct 4, 2017

mericano1 commented Oct 4, 2017 • edited Loading

ulfmaier commented Oct 7, 2017

daffl commented Oct 7, 2017

pepe commented Oct 9, 2017

Cengkaruk commented Nov 8, 2017

binury commented Jun 7, 2017 •

edited by marshallswain

Loading

binury commented Jun 7, 2017 •

edited

Loading

marshallswain commented Jun 7, 2017 •

edited

Loading

luiz-filipe commented Jun 9, 2017 •

edited

Loading

luiz-filipe commented Jun 9, 2017 •

edited

Loading

mericano1 commented Oct 4, 2017 •

edited

Loading

mericano1 commented Oct 4, 2017 •

edited

Loading