Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a local folder option in get_result_df #394

Closed
xiaoyongzhu opened this issue Jun 24, 2022 · 0 comments · Fixed by #400
Closed

add a local folder option in get_result_df #394

xiaoyongzhu opened this issue Jun 24, 2022 · 0 comments · Fixed by #400
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@xiaoyongzhu
Copy link
Member

Currently in the get_result_df function, there's no way to specify a temporary folder name. Will be useful if this function can support a parameter like local_folder or something so end user can control where to download those files.
@xiaoyongzhu xiaoyongzhu added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 24, 2022
shivamsanju added a commit to shivamsanju/feathr that referenced this issue Jun 26, 2022
@shivamsanju
added local_folder param to get_result_df (feathr-ai#394)
8b582d3
@shivamsanju shivamsanju mentioned this issue Jun 26, 2022
Merged
@xiaoyongzhu xiaoyongzhu linked a pull request Jun 27, 2022 that will close this issue
Added local_folder param to get_result_df (#394) #400
Merged
xiaoyongzhu pushed a commit that referenced this issue Jul 6, 2022
@shivamsanju
Added local_folder param to get_result_df (#394) (#400)
ff2759e 
* added local_folder param to get_result_df (#394)

* replaced temp_dir with local_folder to fix undefined variable error

* added docstring and changed local_folder to absolute path

* changed laucher too launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added local_folder param to get_result_df (#394) shivamsanju/feathr
1 participant
@xiaoyongzhu