Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] feature_user_total_purchase_in_90days in get started notebook uses incorrect agg_func #647

Closed
4 tasks
blrchen opened this issue Sep 7, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@blrchen
Copy link
Collaborator

blrchen commented Sep 7, 2022

Willingness to contribute

No. I cannot contribute a bug fix at this time.

Feathr version

v0.7.2

System information

N/A

Describe the problem

In getting start notebook, the agg_func used for feature_user_total_purchase_in_90days is AVG, it should be corrected to SUM

Feature(name="feature_user_total_purchase_in_90days",
                        key=user_id,
                        feature_type=FLOAT,
                        transform=WindowAggTransformation(agg_expr="cast_float(purchase_amount)",
                                                          agg_func="AVG",
                                                          window="90d"))

Tracking information

No response

Code to reproduce bug

No response

What component(s) does this bug affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React
@blrchen blrchen added the bug Something isn't working label Sep 7, 2022
@windoze windoze assigned windoze and unassigned windoze Sep 13, 2022
@loomlike
Copy link
Collaborator

loomlike commented Jan 5, 2023

Thanks for the finding. It will be fixed (to use AVG) along with a fix for the typo in the feature name from the notebook update PR #921

agg_features = [
    Feature(
        name="feature_user_avg_purchase_for_90days",
        key=user_id,
        feature_type=FLOAT,
        transform=WindowAggTransformation(
            agg_expr="cast_float(purchase_amount)", agg_func="AVG", window="90d"
        ),
    )
]

@blrchen blrchen assigned loomlike and unassigned blrchen Jan 5, 2023
@blrchen
Copy link
Collaborator Author

blrchen commented Jan 11, 2023

Closing as this resolved in PR #921.

@blrchen blrchen closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants