-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample notebooks (fraud detection and recommendation examples) to use latest feathr api #921
Merged
xiaoyongzhu
merged 23 commits into
feathr-ai:main
from
loomlike:jumin/update_get_result_df_examples
Jan 6, 2023
Merged
Update sample notebooks (fraud detection and recommendation examples) to use latest feathr api #921
xiaoyongzhu
merged 23 commits into
feathr-ai:main
from
loomlike:jumin/update_get_result_df_examples
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
loomlike
added
the
safe to test
Tag to execute build pipeline for a PR from forked repo
label
Dec 13, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
The feature embedding notebook test error will be fixed once #923 is get merged. |
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
…cies Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
…ure example github Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
blrchen
previously approved these changes
Dec 22, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
loomlike
changed the title
Update fraud_detection notebook to use latest utility api
Update sample notebooks (fraud detection and recommendation examples) to use latest feathr api
Dec 27, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
… US East 2 Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
blrchen
previously approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jun for notebook improvements, let's get this merged for bug bash.
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Closed
4 tasks
blrchen
approved these changes
Jan 5, 2023
xiaoyongzhu
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines and bug-fixes fraud_detection notebook.
The sample data sets are uploaded to public storage as well so that users can run the notebook.
While working on this update, I found an issue #920. You may use the fraud detection notebook in this PR to reproduce the issue.
How was this PR tested?
Notebook tests under /test/samples/
Does this PR introduce any user-facing changes?