Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample notebooks (fraud detection and recommendation examples) to use latest feathr api #921

Merged

Conversation

loomlike
Copy link
Collaborator

@loomlike loomlike commented Dec 13, 2022

Description

This PR refines and bug-fixes fraud_detection notebook.
The sample data sets are uploaded to public storage as well so that users can run the notebook.

While working on this update, I found an issue #920. You may use the fraud detection notebook in this PR to reproduce the issue.

How was this PR tested?

Notebook tests under /test/samples/

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Dec 13, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Copy link
Collaborator Author

The feature embedding notebook test error will be fixed once #923 is get merged.

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
…cies

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
…ure example github

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
blrchen
blrchen previously approved these changes Dec 22, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike loomlike changed the title Update fraud_detection notebook to use latest utility api Update sample notebooks (fraud detection and recommendation examples) to use latest feathr api Dec 27, 2022
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
… US East 2

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
blrchen
blrchen previously approved these changes Jan 4, 2023
Copy link
Collaborator

@blrchen blrchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jun for notebook improvements, let's get this merged for bug bash.

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@xiaoyongzhu xiaoyongzhu merged commit 01ea96d into feathr-ai:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants