Update Dockerfile to point to current nginx.conf file #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @donegjookim, thanks for fixing this. This error was not caught earlier because docker image publishing was only tested on windows. I spent some time test this image on linux and observed one more fix is required, otherwise when you perform Would you mind to include this as part of PR? Its one line change, adding following before line 29 |
donegjookim
force-pushed
the
bugfix/fix-dockerfile
branch
from
121280b
to
3ef465a
Compare
blrchen
approved these changes
Jul 19, 2022
xiaoyongzhu
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the Docker build fails from following the Azure quickstart guide. The error stems from incorrect nginx.conf path:
I verified that the docker build works correctly after the fix.