Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating instructions for publishing to maven. #542

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

blee1234
Copy link
Collaborator

@blee1234 blee1234 commented Aug 1, 2022

Making clearer the substeps, reorganizing steps, and fixed some incorrect parts.

Making clearer the substeps, reorganizing steps, and fixed some incorrect parts.
@xiaoyongzhu
Copy link
Member

Thanks @blee1234 . Seems there were some format changes so there are conflicts so maybe you can also fix this. otherwise looks good to me.

@xiaoyongzhu
Copy link
Member

Thanks @blee1234 ! Adding @jainr to review here

@blee1234 blee1234 merged commit b263585 into main Aug 2, 2022
@blee1234 blee1234 deleted the publish_to_maven_improve branch August 2, 2022 20:56
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
* Updating instructions for publishing to maven.

Making clearer the substeps, reorganizing steps, and fixed some incorrect parts.

* Fixed indentation issue.

* Fixed user-id unclear documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants