Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Access Control Registry APIs to protect post ones #551

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Extend Access Control Registry APIs to protect post ones #551

merged 2 commits into from
Aug 4, 2022

Conversation

Yuqing-cat
Copy link
Collaborator

Included In This PR:

  1. post APIs validated in localhost
  • create project
  • create datasource
    The rest post APIs should have the similar behavior with create datasource.
  1. add global keyword protection and 400 exception class

This PR should be able to unblock the feathrclient sql issue with rbac registry endpoints.

Todo in follow up PRs:

  • Conduct more testing in both local and online deployments to confirm this feature.
  • Extract HttpExceptions into a seperate expection.py

@Yuqing-cat Yuqing-cat added safe to test Tag to execute build pipeline for a PR from forked repo python code is mostly python labels Aug 3, 2022
blrchen
blrchen approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@blrchen blrchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Yuqing-cat Yuqing-cat merged commit 755c1f0 into feathr-ai:main Aug 4, 2022
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
@Yuqing-cat @ahlag
Extend Access Control Registry APIs to protect post ones (feathr-ai…
1330635 
…#551)

* Extend rbac registry APIs to post ones
* Update auth.py to support live.com CLI tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blrchen blrchen blrchen approved these changes

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@jainr jainr Awaiting requested review from jainr

@windoze windoze Awaiting requested review from windoze

Assignees
No one assigned
Labels
python code is mostly python safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yuqing-cat @xiaoyongzhu @blrchen