Downgrade Spark job runtime to use protobuf v2 to make maven jar work. #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is a conflict on protobuf-java versions between job runtime (v3.19.4) and spark runtime (v2.6.1). This will This PR does following to downgrade protobuf usage scala from v3 to v2 to resolve version conflict.
FeatureValueOuterClass.java
with v2 syntaxOn a side note, sbt assembly has a feature to shade/rename dependency, for example following code in build.sbt will rename
com.google.protobuf
toshade.protobuf
,this can resolve the version conflict in fat jar, aka the blob jar published to Azure Storage. However, this can not resolve the issue for maven jar which does not contains any additional dependencies. Downgrade protobuf from v3 to v2 is still required to fix maven jar.
Resolves #616
How was this PR tested?
Following test has been done to verify latest python client can read feature data from online store that is wrotten by protobuf v2
Does this PR introduce any user-facing changes?