remove unnecessary spark job from registry test #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
blrchen
approved these changes
Oct 28, 2022
enya-yx
approved these changes
Oct 28, 2022
|
@Yuqing-cat assuming we have other test cases to cover the E2E test for registry? |
The daily notebook test covers registry E2E, given CI now is taking very long to complete and spark job fails frequently, we should make CI test more scoped and united. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuqing Wei weiyuqing021@outlook.com
Description
Based on CI failure here: https://github.com/feathr-ai/feathr/actions/runs/3279090567/jobs/5398225684#step:8:510
feathr_project/test/test_feature_registry.pyis marked as F but the RuntimeError: Spark job failed. has nothing todo with registry itself.By removing the unnecessary spark job, test cost will be saved and only feature register use case will be tested.
How was this PR tested?
Does this PR introduce any user-facing changes?