Windoze/spark sql source #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windoze
requested review from
jaymo001,
blrchen,
edwincheung,
enya-yx,
xiaoyongzhu and
Yuqing-cat
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
xiaoyongzhu
reviewed
Nov 23, 2022
|
Thanks @windoze for the PR, it's a nice one. A quick high level comment is that maybe we should have a small databricks table setup and add/run E2E test cases. I think the scala unit test looks good, but there might be changes on the python side so we'd better add E2E test to be safe. |
windoze
added
the
safe to test
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
xiaoyongzhu
approved these changes
Jan 6, 2023
|
This LGTM. Thanks @Yuqing-cat and @windoze ! |
blrchen
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
SparkSqlSource. It uses a SparkSQL table name or SQL statement to load data.How was this PR tested?
Unit test has been added.
Does this PR introduce any user-facing changes?
SparkSqlSourcesource type.