Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest cases and check test coverage for sql-registry and purview… #937

Merged
merged 18 commits into from
Jan 10, 2023
Merged

Add pytest cases and check test coverage for sql-registry and purview… #937

merged 18 commits into from
Jan 10, 2023

Conversation

enya-yx
Copy link
Collaborator

@enya-yx enya-yx commented Jan 3, 2023 •
edited
Loading

…-registry

Description

  • Add test cases for sql-registry and purview-registry (server side)
  • Check test coverage and make sure it can get >=90%
  • Modify types annotations; eg. dict->Dict, list->List

How was this PR tested?

  • Check test coverage locally and they are 90% and 91% for sql and purview, respectively:

Screenshot 2023-01-03 at 17 14 05

Screenshot 2023-01-03 at 17 14 27

Does this PR introduce any user-facing changes?

  • [x ] No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@enya-yx enya-yx added safe to test Tag to execute build pipeline for a PR from forked repo and removed safe to test Tag to execute build pipeline for a PR from forked repo labels Jan 3, 2023
@enya-yx enya-yx added the registry test Used to run test cases for registry label Jan 9, 2023
Yuqing-cat
Yuqing-cat previously approved these changes Jan 10, 2023
View reviewed changes
blrchen
blrchen previously approved these changes Jan 10, 2023
View reviewed changes
@enya-yx enya-yx dismissed stale reviews from blrchen and Yuqing-cat via 5c39ff6 January 10, 2023 08:17
@enya-yx enya-yx merged commit c967f6d into feathr-ai:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blrchen blrchen blrchen approved these changes

@windoze windoze windoze approved these changes

@Yuqing-cat Yuqing-cat Yuqing-cat left review comments

@xiaoyongzhu xiaoyongzhu Awaiting requested review from xiaoyongzhu

Assignees
No one assigned
Labels
registry test Used to run test cases for registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enya-yx @windoze @blrchen @Yuqing-cat