Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove code block, which contained import of common antd styles #609

Conversation

corocoto
Copy link
Contributor

@corocoto corocoto commented Jul 30, 2023

Background

Remove code block, which contained import of antd/dist/antd.css. The main reason why I do so - is that this approach doesn't actual at v5 of antd.

For proving it, you can read the list of incompatible changes in v5 on official site, especially "Technology adjustment" block

Css files are no longer included in package. Since CSS-in-JS supports importing on demand, the original antd/dist/antd.css has also been abandoned. If you need to reset some basic styles, please import antd/dist/reset.css.

@netlify
Copy link

netlify bot commented Jul 30, 2023

👷 Deploy request for pr-fsd accepted.

Name Link
🔨 Latest commit ac4fd46
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/64c6527f255c0f0008637562

@corocoto corocoto changed the title docs: Remove code block, which contained importing common antd css file docs: Remove code block, which contained import of common antd styles Jul 30, 2023
@azinit
Copy link
Member

azinit commented Aug 4, 2023

@feature-sliced/core

@illright illright merged commit 15af670 into feature-sliced:master Aug 6, 2023
2 checks passed
@corocoto corocoto deleted the docs/update-uikit-connection-section branch August 6, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants