Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file loading using CLI argument #326

Merged
merged 3 commits into from
Jul 14, 2018

Conversation

OlivierBlanvillain
Copy link
Contributor

The Leela 11 GUI from https://sjeng.org/leela.html has the same behavior, UNIX users might prefer that way of opening files over the Java dialog.

(I hope I'm not spamming too much with the 3 PRs, they are pretty unrelated so I figured I should open separate ones)

With this change it becomes possible to quickly load files from the CLI:

java -jar Lizzie.jar /path/to/game.sgf

Which is equivalant to

- java -jar Lizzie.jar
- press o
- select /path/to/game.sgf using the java dialog
@featurecat featurecat merged commit a0b2a70 into featurecat:next Jul 14, 2018
@featurecat
Copy link
Owner

no it's good I prefer the 3. thank you. you also fixed the filename extension issue. does it still work with .gib files?

@OlivierBlanvillain
Copy link
Contributor Author

you also fixed the filename extension issue. does it still work with .gib files?

I'm not sure what issue you are referring too, both .gib and .sgf work fine for me on master and next, and they can both be loaded from the CLI after this PR.

The commit where I touched saveSgf and openSgf is only renaming these methods to a more accurate name that reflect the fact that they handle both .sgf and .gib!

@OlivierBlanvillain OlivierBlanvillain deleted the open-file-from-cli branch July 14, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants