Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Webpack #2708

Closed
Tracked by #207
rfultz opened this issue Feb 28, 2019 · 4 comments · Fixed by #6263
Closed
Tracked by #207

Upgrade Webpack #2708

rfultz opened this issue Feb 28, 2019 · 4 comments · Fixed by #6263

Comments

@rfultz
Copy link
Contributor

rfultz commented Feb 28, 2019

We should look into upgrading Webpack.

When upgrading Node and the testing packages, I found that upgrading to the latest webpack (4) caused our bundling to break. A little research led me to a dependency that didn't like how we were using CommonsChunkPlugin (and how it would transition to the SplitChunksPlugin, since CommonsChunkPlugin is deprecated in webpack 4) and that it'll be fixed in a forthcoming release.

Remember: watch webpack plugin releases.
Option: re-evaluate how we're using Webpack?

Followup work:

@rfultz
Copy link
Contributor Author

rfultz commented Apr 17, 2019

@patphongs, I'm increasing the priority here. The security issue with tar's version #2821 has been solved for node-gyp@4 but not for our node-gyp@3.8.0 (yet). I'd like not to postpone the Webpack upgrade until there's a pressing security issue and we have to rush to upgrade.

@rfultz
Copy link
Contributor Author

rfultz commented Nov 12, 2019

Upgrading Webpack should make our site load faster, too. Google may be looking at that soon: https://www.engadget.com/2019/11/11/chrome-slow-loading-websites-speed-badging-label/

@rfultz rfultz self-assigned this Apr 6, 2020
@rfultz
Copy link
Contributor Author

rfultz commented Apr 6, 2020

We've waited long enough that Webpack 5 is under construction (probably 65% there, by their Git milestone). No current release date announced. It's still in beta and there are several other packages who only support Webpack 5 with their beta versions.

@rfultz
Copy link
Contributor Author

rfultz commented Apr 6, 2020

Researched this week and got the structure of our current build transitioned to Webpack 4.
Next problems to solve:

  • dev build takes > 38s
  • prod build takes > 500s
  • exported files are larger than from Webpack 4

Next steps:

  • Enable dev hotswap (replacing npm watch, I suspect)
  • Work with SplitChunks and CDN

@JonellaCulmer JonellaCulmer added this to the Sprint 24.2 milestone Feb 13, 2024
@patphongs patphongs moved this to In Progress in Website project Feb 23, 2024
@rfultz rfultz modified the milestones: Sprint 24.2, Sprint 24.3 Feb 27, 2024
@johnnyporkchops johnnyporkchops modified the milestones: 24.3, 24.4 Mar 12, 2024
@tmpayton tmpayton modified the milestones: 24.4, 24.5 Apr 2, 2024
@pkfec pkfec modified the milestones: 24.5, 25.1 Apr 23, 2024
@rfultz rfultz moved this from 🏗 In Progress to 👀 Ready in Website project May 15, 2024
@cnlucas cnlucas modified the milestones: 25.1, 25.2 May 28, 2024
@cnlucas cnlucas modified the milestones: 25.2, 25.3 Jun 11, 2024
@rfultz rfultz modified the milestones: 25.3, 25.4 Jun 25, 2024
@rfultz rfultz modified the milestones: 25.4, 25.5 Jul 9, 2024
@rfultz rfultz modified the milestones: 25.5, 25.6 Jul 23, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready to ✅ Done in Website project Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

10 participants