PR: 6179, 6180 national party account

[rfultz]

Summary

• Resolves Build national party account receipts datatable #6179
• Resolves Build national party account disbursements datatable #6180

Building the front-end for the national party accounts' receipts and disbursements datatables

Required reviewers

• UX
• Front-end for code
• Back-end and/or SMEs for data accuracy

Impacted areas of the application

• A couple new feature flags
• A couple new URLs
• A new link from /data/browse-data/?tab=raising
• A new link from /data/browse-data/?tab=spending
• A couple new datatables
• I snuck in fixes for a few typos and cleaned up some page source

Screenshots

Receipts	Disbursements
tab:	tab:
datatable:	datatable:

Related PRs

Related PRs against other branches:

None for CMS

Known issues

UX and SMEs: when the right-side details panel is open, it scoots down lower than the table. Should we lose a table column?

How to test

• Pull the branch
• With env vars or directly in base.py,
  • make sure FEC_API_URL points to stage
  • add a valid API key
• npm i
• npm run build
• ./manage.py runserver

Default, with feature flags on for localhost:

• /data/browse-data/?tab=raising should offer an option for 'National party account receipts'
• /data/browse-data/?tab=spending should offer an option for 'National party account disbursements'
• Both of those pages should link to their respective tables
• Check all filters
• Spot check a wide variety of lines' ➲ details panel

To test feature flag:

• For receipts
  1. base.py, line 113, comment out FEATURES['nat_party_acct_receipts'] = True, save
  2. /data/browse-data/?tab=raising should no longer mention 'National party account receipts'
  3. The national party account receipts datatable page should throw a 404
  4. Restore the code in base.py, save
• For disbursements
  1. base.py, line 114, comment out FEATURES['nat_party_acct_disbursements'] = True, save
  2. /data/browse-data/?tab=raising should no longer mention 'National party account disbursements'
  3. The national party account disbursements datatable page should throw a 404
  4. Restore the code in base.py, save

⭐️ Next steps ⭐️

Linked tickets will need updates to stay in sync with the Webpack #2708 upgrade

[codecov]

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.01%. Comparing base (e5df5a7) to head (8624a77).
Report is 2 commits behind head on develop.

Files	Patch %	Lines
fec/fec/static/js/modules/filters/select-filter.js	33.33%	2 Missing ⚠️
fec/fec/static/js/modules/helpers.js	75.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6273      +/-   ##
===========================================
+ Coverage    78.00%   78.01%   +0.01%     
===========================================
  Files          291      291              
  Lines         9414     9447      +33     
  Branches       681      687       +6     
===========================================
+ Hits          7343     7370      +27     
- Misses        2071     2077       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[patphongs]

A couple of fixes for you @rfultz. There's some data issues in the API with line number data, but that's something that @bmathesonFEC is looking at. Let's target these changes for the release branch instead, so we're not pressured to have this in before the cut today. Nothing here that I paired with both @bmathesonFEC and @JonellaCulmer on this review, so we have the necessary required reviewers.

[patphongs]

This needs to be a typeahead.field so that they can select a committee if it's there. Or just search by the name without selecting from the list.

[patphongs]

@rfultz One more thing we noticed is that not all the filters (especially the newer ones added here) are not hooked up to the search tags or passed through as URL query parameters. Could you please add this capability so we can remain consistent?

[JonellaCulmer]

@rfultz We're missing committee clickthroughs to committee profile pages. Clicking on a committee name in the table should take you to their profile page.

cc: @patphongs

[rfultz]

@rfultz We're missing committee clickthroughs to committee profile pages. Clicking on a committee name in the table should take you to their profile page.

cc: @patphongs

Will be part of the next commit/push

[patphongs]

@rfultz Thanks for taking care of these fixes. I just have one small fix

[patphongs]

Thanks for pushing up the last few changes @rfultz! This looks good to go 👍