Add admin API client #122
Add admin API client #122
Conversation
benesch
force-pushed
the
admin-client
branch
3 times, most recently
from
131dcd4 to
6143701
Compare
|
Ok, fixed a few bugs and got tests passing. This is at least ready for review! (No rush! I realize this is quite a bit of code.) |
|
I've used this branch to create and delete topics, and it works like a charm. Except for testing, is there anything else I can do to help out and get this PR merged? |
|
This looks great and it would be useful. What is the status of this PR ? |
|
We've been using this patch successfully at @MaterializeInc for a while now. It's waiting on a review from either @fede1024 or @flavray, both of whom I think have little time to dedicate to maintenance these days, unfortunately. |
|
Hi, thank you for contributing and sorry for the very very slow response time on our side. The change looks good. Would you mind resolving the configs? |
|
It's quite alright, @fede1024! Thank you for finding the time. I've solved the rebase conflicts; hopefully should be good to go once CI passes. |
benesch
force-pushed
the
admin-client
branch
6 times, most recently
from
e16edca to
d871af4
Compare
After diving into the librdkafka source, this is a valid return value for metadata.orig_broker_id().
|
Woohoo, it's green! The last commit is new, and it took a bit to figure out what was going on. Looks like we're now tickling a different code path inside librdkafka in test_metadata and getting metadata from bootstrap "broker" -1 instead of 0, which is perfectly valid and expected (see confluentinc/librdkafka@f50747e). |
|
Great work, thank you! |
There's probably a few more bugs here to shake out, but this is mostly ready to go.
This is based off of #119/#120. It's not technically tied to any of the changes in #119/#120, if for some reason we want to land this before those PRs.Fix #92.