Pass KafkaError to rebalance hooks #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborst
force-pushed
the
provide-rich-error-in-rebalance
branch
2 times, most recently
from
1e2eae9 to
f12e31e
Compare
mborst
force-pushed
the
provide-rich-error-in-rebalance
branch
from
f12e31e to
f7d293b
Compare
davidblewett
approved these changes
May 16, 2023
mborst
force-pushed
the
provide-rich-error-in-rebalance
branch
from
f7d293b to
e0fd496
Compare
It is easier to build generic error handling on top of error codes than on top of the librdkafka-defined string representations intended for human consumption.
mborst
force-pushed
the
provide-rich-error-in-rebalance
branch
from
e0fd496 to
9674a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier to build generic error handling on top of error codes than on top of the librdkafka-defined string representations intended for human consumption.