Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run build and check workflows on org github repo #944

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kwk
Copy link
Collaborator

@kwk kwk commented Dec 18, 2024

We've identified people modifying the our org's copr repo by accident. This ensures for NEW forks, that this won't happen again by accident. Existing forks need to be adapted manually to avoid this modification.

@kwk kwk requested a review from nikic December 18, 2024 11:02
Copy link
Collaborator

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to disable the workflows entirely using if: github.repository_owner == 'fedora-llvm-team'. I don't think people forking this repo actually want to run their own copy of the snapshots, right?

@kwk
Copy link
Collaborator Author

kwk commented Dec 18, 2024

I think it would be better to disable the workflows entirely using if: github.repository_owner == 'fedora-llvm-team'. I don't think people forking this repo actually want to run their own copy of the snapshots, right?

Agreed but I would still keep this change then.

@nikic
Copy link
Collaborator

nikic commented Dec 18, 2024

I think it would be better to disable the workflows entirely using if: github.repository_owner == 'fedora-llvm-team'. I don't think people forking this repo actually want to run their own copy of the snapshots, right?

Agreed but I would still keep this change then.

I'm not really sure this makes sense. Note that this assumes that the github user name matches the copr name -- including the @ prefix for groups. This is going to work for @fedora-llvm-team, but not for any of the user forks, even if the github and copr usernames happen to match.

@kwk
Copy link
Collaborator Author

kwk commented Dec 18, 2024

I think it would be better to disable the workflows entirely using if: github.repository_owner == 'fedora-llvm-team'. I don't think people forking this repo actually want to run their own copy of the snapshots, right?

Agreed but I would still keep this change then.

I'm not really sure this makes sense. Note that this assumes that the github user name matches the copr name -- including the @ prefix for groups. This is going to work for @fedora-llvm-team, but not for any of the user forks, even if the github and copr usernames happen to match.

Alright, alright you got me :)

@kwk kwk force-pushed the modify-individual-coprs branch from 52eb71d to 01669fa Compare December 18, 2024 13:56
@kwk kwk changed the title Github forks MUST modify their own copr project and not our Only run build and check workflows on org github repo Dec 18, 2024
@kwk kwk merged commit 0bd3ccc into fedora-llvm-team:main Dec 18, 2024
4 of 5 checks passed
@kwk kwk deleted the modify-individual-coprs branch December 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants