Assorted fixes for MBS #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be in the same order as the function definition. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
It's unsafe to call g_variant_new_from_data() with data living within another GVariant. The appropriate way to do this is to copy the data into a new buffer, then create the new GVariant from that (and set a GDestroyNotify function to free the buffer when it's done). Fixes: fedora-modularity#274 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a patch to reorder the
strictargument forModuleStream.read_*()so that it appears in the same order in the docs as in the function arguments. (Related to #273)Adds a test for unicode in stream descriptions (related to #275)
Adds a fix for a subtle memory-management issue in XMD. (Fixes #274)