fix: return support for network-scripts for Fedora 40 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnykryn
approved these changes
Apr 16, 2024
| Obsoletes: %{name} < 9.82-2 | ||
|
|
||
| # This is legacy and deprecated, so nobody should depend on this! | ||
| # If ifcfg-style configuration is still desired, NetworkManager can do this. |
There was a problem hiding this comment.
Are we sure about this? I know that NM at least planned to drop support for ifcfg files
There was a problem hiding this comment.
right now NetworkManager-initscripts-ifcfg-rh still exists in all current branches. I think there is an intent to retire it eventually, though. It is not installed by default since https://fedoraproject.org/wiki/Changes/NoIfcfgFiles (F36).
|
I don't see any "if < 41" conditionals or anything in this, so doesn't this also return it to Rawhide? Is that intended? I guess it's correct at least until a Change for F41 is submitted and approved. |
|
@AdamWill I have returned Once accepted I plan to revert this commit. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts commit b751727 and e35db93
Resolves: #2274830