feature(draggable): added drag ability to positioned dialog #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code clean made
…log. Remove deprecated and unnecessary rules in analysis_options. Add trailing commas for better code formatting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 94.17% 96.66% +2.49%
==========================================
Files 17 18 +1
Lines 738 750 +12
==========================================
+ Hits 695 725 +30
+ Misses 43 25 -18 ☔ View full report in Codecov by Sentry. |
- Removed isDraggable property from PositionedDialog and related usage in positioned_dialog_basic_usage.dart - Introduced FreePositioned widget to handle draggable functionality - Added draggable method in EasyDialogsController to apply draggable decoration - Updated PositionedDialog to use Align widget instead of _FreePositioned - Updated tests to cover new draggable feature - Updated CHANGELOG.md to reflect changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
closes #23
Type of Change