Use dynamic import expression to load plugin code #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets plugins choose whether to be es modules or not at the package level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets plugins choose whether to be es modules or not at the package level.
Shockingly easy server change to allow es modules in server side plugin code. Import expressions have been available and stable in node since at least v12, but this won't work in very old versions. By default this will still load server side plugins as common js modules because it hard codes the
.jsfile extension, to switch a plugin to esmodules add"type": "module"to the top level of its package.jsonRelated to, but not dependent on fedwiki/wiki-client#320