Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scaling from spring example #39

Open
francoisdh opened this issue Jun 21, 2018 · 4 comments
Open

Remove scaling from spring example #39

francoisdh opened this issue Jun 21, 2018 · 4 comments
Assignees
@francoisdh
Labels
type:improvement Add or improve the functionality for an existing capability.

Comments

@francoisdh
Copy link
Contributor

We would like to remove the scaling of the spring example. The unit defined at the first line of docs/modules/centerlines/examples/spring/spring.geo should be 0.1 instead of 10.

This would then allow to remove gmsh.scale=1e-2 option in Feel++ toolboxes spring examples: https://github.com/feelpp/toolbox/blob/master/examples/modules/cfd/examples/spring/spring.cfg

This 100x scaling was introduced as a workaround which should not be required anymore.
@francoisdh francoisdh added the type:improvement Add or improve the functionality for an existing capability. label Jun 21, 2018
@francoisdh francoisdh self-assigned this Jun 21, 2018
francoisdh added a commit that referenced this issue Jun 21, 2018
@francoisdh
Started working on issue #39: removing spring example scaling. This i…
f65f560 
…s still work in progress.

Updated geo and cfg files in docs/modules/centerlines/examples/spring/:
	- spring.geo
	- centerlinesmanager.cfg
	- imagefromcenterlines.cfg
	- surfacefromimage.cfg
	- remeshstlgmsh.cfg

Note: This is not enough to fix issue #39, angiotk_meshing_remeshstl now seems to hang or run into infinite loop (using 100% cpu) at "run OpenSurface" step. Last output line:
"Info    : AngioTkCenterline: prepare data for cutting done"
@francoisdh francoisdh mentioned this issue Jun 21, 2018
Closed
@francoisdh
Copy link
Contributor Author

Status update:

The last commit is not enough to fix issue #39, angiotk_meshing_remeshstl now seems to hang or run into infinite loop (using 100% cpu) at "run OpenSurface" step.
Last output line:

Info    : AngioTkCenterline: prepare data for cutting done

@prudhomm
Copy link
Member

@francoisdh do you know how to fix that ?

@vincentchabannes any idea ?

@prudhomm
Copy link
Member

@francoisdh you should provide some more information and look for yourself also in the code to understand where it gets "stuck"

@francoisdh
Copy link
Contributor Author

@prudhomm Ok, I will look it up. I just wanted to post an update about it and ask if there was an already known problem/solution I didn't know about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francoisdh francoisdh

Labels
type:improvement Add or improve the functionality for an existing capability.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prudhomm @francoisdh