Added Video Support #137

anjnkmr · 2017-01-02T05:31:23Z

I used this script in our site, and we need a requirement of video on popup, so i modified the code the add video support

feimosi · 2017-01-02T19:16:03Z

Thanks for your contribution, that looks like quite a lot of new code. I'm gonna need more time to review it.
Could you please remove dist/ folder from this PR? I take care of releases myself. Also there seem to be linting errors.

anjnkmr · 2017-01-03T03:54:33Z

Remove unmodified files from pull request

feimosi · 2017-01-03T10:04:22Z

Sorry, you must have misunderstood me. I meant remove dist/ folder changes in this PR, not the whole folder itself.

Just leave src/ changes which are relevant to me. I update dist/ and demo/ myself. Thanks.

anjnkmr · 2017-01-03T11:05:44Z

Hi @feimosi please check now
I see something failed here

"continuous-integration/travis-ci/pr",

i don't understand what is this

feimosi · 2017-01-03T11:17:01Z

Seems fine now. Just unnecessary empty first line in .editorconfig and demo/index.html

I don't understand what is this

It's linter errors. You can see more details here:
https://travis-ci.org/feimosi/baguetteBox.js/jobs/188491776#L188

anjnkmr · 2017-01-04T03:40:47Z

I fixed the warnings and removed first empty line in .editorconfig file,
thanks for explanation
and this is my first contribution in github

feimosi · 2017-01-04T20:29:36Z

Great, I'll take a look in some free time.
No problem if it's your first contribution. We're here to help :)

Also, you may want to read about git commit --amend, so you don't create so many commits.

anjnkmr · 2017-01-05T03:30:08Z

thank you

…

On Thu, Jan 5, 2017 at 1:59 AM, Marek Grzybek ***@***.***> wrote: Great, I'll take a look in some free time. No problem if it's your first contribution. We're here to help :) Also, you may want to read about git commit --amend, so you don't create so many commits. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#137 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQHDAmi036Wi0NjvRvYFi7E35MpyVmWYks5rPAExgaJpZM4LY1-q> .

XhmikosR · 2017-05-21T21:49:28Z

demo/index.html

@@ -1,3 +1,4 @@
+


This shouldn't be here.

XhmikosR · 2017-05-21T21:50:01Z

src/baguetteBox.js

    function loadImage(index, callback) {
        var imageContainer = imagesElements[index];
        var galleryItem = currentGallery[index];
+        var isVideo = false;
+        if(imageContainer !== undefined) {


Missing space/ Also better use typeof imageContainer !== 'undefined'

XhmikosR · 2017-05-21T21:50:23Z

src/baguetteBox.js

@@ -490,11 +515,23 @@

        // Get element reference, optional caption and source path
        var imageElement = galleryItem.imageElement;
-        var thumbnailElement = imageElement.getElementsByTagName('img')[0];
+        var thumbnailElement = null;
+        if(isVideo) {


Missing space afyer if.

XhmikosR · 2017-05-21T21:50:32Z

src/baguetteBox.js

+        var thumbnailElement = null;
+        if(isVideo) {
+            thumbnailElement = imageElement.getElementsByTagName('video')[0];
+        }


else should be on the same line.

XhmikosR · 2017-05-22T04:18:07Z

src/baguetteBox.js

@@ -477,7 +477,7 @@

    function pauseAnyVideoPlaying(){
        [].forEach.call(imagesElements, function(imageElement) {
-            if(imageElement.getElementsByTagName('video').length > 0){
+            if (imageElement.getElementsByTagName('video').length > 0){


Space before brackets.

hi, do you want me to remove the spaces before brackets

No, you should always use it as per the rest of the codebase.

XhmikosR · 2017-05-22T04:18:12Z

src/baguetteBox.js

            isVideo = videoRegex.test(galleryItem.imageElement.href);
        }

        // Return if the index exceeds prepared images in the overlay
        // or if the current gallery has been changed / closed
-        if (imageContainer === undefined || galleryItem === undefined) {
+        if (typeof imageContainer === 'undefined'|| typeof galleryItem === 'undefined') {


space before ||

XhmikosR · 2017-05-22T04:18:40Z

src/baguetteBox.js

            thumbnailElement = imageElement.getElementsByTagName('img')[0];
        }
        var imageCaption = typeof options.captions === 'function' ?
                            options.captions.call(currentGallery, imageElement) :
                            imageElement.getAttribute('data-caption') || imageElement.title;
        var imageSrc = null;
-        if(isVideo) {
+        if (isVideo) {
            imageSrc = getVideoSrc(imageElement);
        }


You should use else in the same line as the brackets.

XhmikosR · 2017-05-22T04:25:52Z

src/baguetteBox.js

    function loadImage(index, callback) {
        var imageContainer = imagesElements[index];
        var galleryItem = currentGallery[index];
+        var isVideo = false;
+        if typeof imageContainer !== 'undefined' {


This is wrong now; you are missing the parentheses.

XhmikosR · 2017-05-22T04:27:41Z

src/baguetteBox.js

@@ -490,11 +515,21 @@

        // Get element reference, optional caption and source path
        var imageElement = galleryItem.imageElement;
-        var thumbnailElement = imageElement.getElementsByTagName('img')[0];
+        var thumbnailElement = null;


You could change this whole thing into a one liner

var thumbnailElement = isvideo ? imageElement.getElementsByTagName('video')[0] : imageElement.getElementsByTagName('img')[0];

thank you fixing

XhmikosR · 2017-05-22T04:28:22Z

src/baguetteBox.js

        var imageCaption = typeof options.captions === 'function' ?
                            options.captions.call(currentGallery, imageElement) :
                            imageElement.getAttribute('data-caption') || imageElement.title;
-        var imageSrc = getImageSrc(imageElement);
+        var imageSrc = null;


Same here as https://github.com/feimosi/baguetteBox.js/pull/137/files#r117660076

XhmikosR · 2017-05-22T04:39:41Z

src/baguetteBox.js

+        }
+
+        // If video is already loaded run callback and return
+        if (imageContainer.getElementsByTagName('video')[0] && isVideo) {


This is the same as above

can you please explain what is problem here, i don't understand

You can merge this condition with the previous one instead of duplicating.

thanks merged

XhmikosR · 2017-05-22T04:39:58Z

src/baguetteBox.js

-        var imageSrc = getImageSrc(imageElement);
-
+        var imageSrc = isVideo ? getVideoSrc(imageElement) : getImageSrc(imageElement);
+        


Trailing spaces.

XhmikosR · 2017-05-22T05:30:00Z

src/baguetteBox.js

-        // If image is already loaded run callback and return
-        if (imageContainer.getElementsByTagName('img')[0]) {
+        // If image is already loaded run callback and return OR If video is already loaded run callback and return
+        if ((imageContainer.getElementsByTagName('img')[0] && !isVideo) || (imageContainer.getElementsByTagName('video')[0] && isVideo)) {


Is the && !isVideo needed?

yes, it is needed

rafaberaldo · 2017-08-28T12:11:46Z

Any update on this @feimosi ?

feimosi · 2017-09-16T11:23:15Z

@rafaelpimpa Sorry, it needs more time from my side because it introduces too many changes and I don't have much time lately.

elber-rodrigues04 · 2022-08-04T11:03:25Z

Hi feimosi my name is Elber and I'm a Baguette.box's maintainer in Drupal.org (please see it: https://www.drupal.org/project/baguettebox) we have an issue with the same target of this pull request (please see it: https://www.drupal.org/project/baguettebox/issues/3261916) for keep working on that issue I need you commit this changes here.

Please don't forget of this comment.

Thank you all.

smustgrave · 2024-03-23T16:05:34Z

Wonder if this is still being used on 1.11.1?

ranjankumarzonup added 10 commits January 2, 2017 10:50

Added Video Support

dc68d00

Added Video Support

a84b2bb

Added Video Support

a341970

Added Video Support

6b5ec5f

Added Video Support

e4b95f7

Added Video Support

662130e

Added Video Support

fd0bb45

Removed Console Logs

ef8639d

Removed Console Logs

1ef2c62

Removed Console Logs

24935f8

ranjankumarzonup added 6 commits January 3, 2017 09:21

Removing Dist File

7f5f62d

Removed Dist Files

9827746

Removed Dist Files

3828e6d

Removed Dist Files

9a17e2b

Removing Unmodified Files

8f558e4

Removing Unmodified Files

4f05c46

ranjankumarzonup added 4 commits January 3, 2017 16:30

Reverted changes

8d6b47d

Revereted Changes

8f9faf1

Reverted Changes

0034778

Reverted Changes

c49d9f4

ranjankumarzonup added 3 commits January 4, 2017 09:04

Updating Linting Errors

87ac750

Removed unecessary empty space

39e4152

Updated Linting Warnings

12b0eeb

XhmikosR reviewed May 21, 2017

View reviewed changes

demo/index.html Outdated

@@ -1,3 +1,4 @@

Copy link

Contributor

XhmikosR May 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here.

XhmikosR reviewed May 21, 2017

View reviewed changes

Fixed the issues mentioned by @XhmikosR

af7da8b

XhmikosR reviewed May 22, 2017

View reviewed changes

Fixed the issues mentioned by @XhmikosR feimosi#2

250e5a3

XhmikosR reviewed May 22, 2017

View reviewed changes

Fixed the issues mentioned by @XhmikosR feimosi#3

acf93a1

XhmikosR reviewed May 22, 2017

View reviewed changes

ranjankumarzonup added 2 commits May 22, 2017 10:18

Fixed the issues mentioned by @XhmikosR feimosi#4

f8d7c97

Fixed the issues mentioned by @XhmikosR feimosi#5 (Merged)

44e4819

XhmikosR reviewed May 22, 2017

View reviewed changes

Anjan Kumar added 2 commits May 30, 2017 15:22

Update index.html

ef25913

Update baguetteBox.js

a4cb9b8

feimosi force-pushed the dev branch from a226a6e to d3a11cb Compare July 6, 2017 20:30

feimosi added the feature label Sep 16, 2017

feimosi force-pushed the dev branch from 65f6b6e to 6e8fc24 Compare March 31, 2020 11:25

jacksonloper mentioned this pull request Sep 17, 2021

Video, HTML and/or iframe support #185

Open

InSAnUA approved these changes Jul 4, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Video Support #137

Added Video Support #137

anjnkmr commented Jan 2, 2017

feimosi commented Jan 2, 2017

anjnkmr commented Jan 3, 2017

feimosi commented Jan 3, 2017

anjnkmr commented Jan 3, 2017 •

edited

Loading

feimosi commented Jan 3, 2017

anjnkmr commented Jan 4, 2017

feimosi commented Jan 4, 2017

anjnkmr commented Jan 5, 2017 via email

XhmikosR May 21, 2017

XhmikosR May 21, 2017

XhmikosR May 21, 2017

XhmikosR May 21, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

XhmikosR May 22, 2017

XhmikosR May 22, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

XhmikosR May 22, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

XhmikosR May 22, 2017

XhmikosR May 22, 2017

anjnkmr May 22, 2017

rafaberaldo commented Aug 28, 2017

feimosi commented Sep 16, 2017

elber-rodrigues04 commented Aug 4, 2022

smustgrave commented Mar 23, 2024

		var imageSrc = getImageSrc(imageElement);

		var imageSrc = isVideo ? getVideoSrc(imageElement) : getImageSrc(imageElement);

Added Video Support #137

Are you sure you want to change the base?

Added Video Support #137

Conversation

anjnkmr commented Jan 2, 2017

feimosi commented Jan 2, 2017

anjnkmr commented Jan 3, 2017

feimosi commented Jan 3, 2017

anjnkmr commented Jan 3, 2017 • edited Loading

feimosi commented Jan 3, 2017

anjnkmr commented Jan 4, 2017

feimosi commented Jan 4, 2017

anjnkmr commented Jan 5, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaberaldo commented Aug 28, 2017

feimosi commented Sep 16, 2017

elber-rodrigues04 commented Aug 4, 2022

smustgrave commented Mar 23, 2024

anjnkmr commented Jan 3, 2017 •

edited

Loading