Back to erroring out when encountering unused variables

feincms · Sep 11, 2024 · 1d10777 · 1d10777
1 parent c15796e
commit 1d10777
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/content_editor/static/content_editor/content_editor.js b/content_editor/static/content_editor/content_editor.js
@@ -14,14 +14,14 @@
       set(name, value) {
         try {
           storage.setItem(prefix + name, JSON.stringify(value))
-        } catch (_e) {
+        } finally {
           /* empty */
         }
       },
       get(name) {
         try {
           return JSON.parse(storage.getItem(prefix + name))
-        } catch (_e) {
+        } finally {
           /* empty */
         }
       },
@@ -209,7 +209,7 @@
         e.dataTransfer.effectAllowed = "move"
         try {
           e.dataTransfer.setData("text/plain", "")
-        } catch (_e) {
+        } finally {
           // IE11 needs this.
         }
 
@@ -363,7 +363,7 @@
       }
       const debouncedIndentInlines = debounce(updateSections, 10)
 
-      const resizeObserver = new ResizeObserver((entries) => {
+      const resizeObserver = new ResizeObserver((_entries) => {
         debouncedIndentInlines()
       })
       resizeObserver.observe(orderMachineWrapper[0])

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -8,7 +8,10 @@ export default [
   pluginJs.configs.recommended,
   {
     rules: {
-      "no-unused-vars": "warn"
+      "no-unused-vars": [
+        "error",
+        {argsIgnorePattern: "^_", varsIgnorePattern: "^_"}
+      ]
     },
   },
 ];