Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bloc_test): add await before expect #3976

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix(bloc_test): add await before expect #3976

merged 2 commits into from
Oct 27, 2023

Conversation

gallottino
Copy link
Contributor

Status

READY

Breaking Changes

NO

Description

Closes #3975

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:bloc_test This issue is related to the bloc_test package labels Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (950d70d) 100.00% compared to head (99b884f) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #3976    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           24         3    -21     
  Lines          560        82   -478     
==========================================
- Hits           560        82   -478
Files Coverage Δ
packages/bloc_test/lib/src/bloc_test.dart 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

felangel
felangel approved these changes Oct 27, 2023
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution and apologies for the delayed review! 💙

@felangel felangel merged commit e23d476 into felangel:master Oct 27, 2023
7 checks passed
@08109165220 08109165220 mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@gallottino gallottino

Labels
bug Something isn't working pkg:bloc_test This issue is related to the bloc_test package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: async expect using blocTest
2 participants
@gallottino @felangel