Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Jenkins Hash #40

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Use Jenkins Hash #40

merged 1 commit into from
Nov 18, 2019

Conversation

felangel
Copy link
Owner

@felangel felangel commented Nov 17, 2019 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

Todos

  • Tests
  • Documentation
  • Examples

Impact to Remaining Code Base

  • Reduce hash collisions

@felangel felangel added the enhancement New feature or request label Nov 17, 2019
@felangel felangel self-assigned this Nov 17, 2019
@codecov-io
Copy link

codecov-io commented Nov 17, 2019 •
edited
Loading

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          39     42    +3     
=====================================
+ Hits           39     42    +3
Impacted Files Coverage Δ
lib/src/equatable_utils.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90567e4...550318d. Read the comment docs.

@felangel felangel force-pushed the feature/jenkins-hash branch from c569dd6 to 550318d Compare November 17, 2019 22:17
@felangel
Copy link
Owner Author

@davidmorgan can you please take a look if you have some time?

davidmorgan
davidmorgan approved these changes Nov 18, 2019
View reviewed changes
Copy link

@davidmorgan davidmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

xsahil03x
xsahil03x approved these changes Nov 18, 2019
View reviewed changes
Copy link

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felangel felangel merged commit 4d8aff3 into master Nov 18, 2019
@felangel felangel deleted the feature/jenkins-hash branch November 18, 2019 17:32
@felangel felangel mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmorgan davidmorgan davidmorgan approved these changes

@xsahil03x xsahil03x xsahil03x approved these changes

Assignees

@felangel felangel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felangel @codecov-io @davidmorgan @xsahil03x