Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin requests dependency to work around docker-py incompatibility #972

Merged
merged 1 commit into from
May 22, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented May 22, 2024

🗣 Description

Pin requests to work around an incompatibility with docker Python API.

💭 Motivation and context

I normally would wait this out, but FoundryVTT just released version 12.
This can be reverted once the PR below is released by Docker.

See:

🧪 Testing

Locally and in CI.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@felddy felddy self-assigned this May 22, 2024
@felddy felddy enabled auto-merge May 22, 2024 21:55
@felddy felddy merged commit eda1ac1 into develop May 22, 2024
38 checks passed
@felddy felddy deleted the foundryvtt-pin-requests branch May 22, 2024 21:59
@felddy felddy mentioned this pull request May 23, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant