Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add local use and tests of workflows #165

Merged
merged 18 commits into from
Jan 18, 2024
Merged

Conversation

felddy
Copy link
Owner

@felddy felddy commented Jan 18, 2024

🗣 Description

This PR refactors some of the jobs in this repo.
More importantly, it adds a multi-architecture container build that uses most of the reusable workflows.

💭 Motivation and context

It became apparent with the recent actions/artifact-upload debacle that the reusable workflows need more testing.
Previously, changes would be made to the workflows, and then you'd have to wait until something broke in one of the
dependent repos.

With this change we should be able to see breakages in the PRs to this repo more often.
Continuous failure!

This is in preparation of applying the major changes needed to use the new v4 immutable artifacts.

🧪 Testing

Tested in CI, and on my local machine.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@felddy felddy self-assigned this Jan 18, 2024
@felddy felddy merged commit 960ca10 into develop Jan 18, 2024
27 checks passed
@felddy felddy deleted the enhancement/refactor branch January 18, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant