-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and add local use and tests of workflows #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for Docker container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR refactors some of the jobs in this repo.
More importantly, it adds a multi-architecture container build that uses most of the reusable workflows.
💭 Motivation and context
It became apparent with the recent actions/artifact-upload debacle that the reusable workflows need more testing.
Previously, changes would be made to the workflows, and then you'd have to wait until something broke in one of the
dependent repos.
With this change we should be able to see breakages in the PRs to this repo more often.
Continuous failure!
This is in preparation of applying the major changes needed to use the new v4 immutable artifacts.
🧪 Testing
Tested in CI, and on my local machine.
✅ Pre-approval checklist
to reflect the changes in this PR.