Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with windows home path #54

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Added compatibility with windows home path #54

merged 1 commit into from
Jun 14, 2017

Conversation

DamonOehlman
Copy link
Contributor

While I usually develop on a mac, I thought I'd take the new BashOnWindows stuff for a spin. This was one blocker, though I believe there are some additional blockers with regards to locating git etc. Happy to work through these to keep resolving those if that's something of interest to you.

@DamonOehlman
Copy link
Contributor Author

And looks like the git error can easily be removed by updating the checkRemoteOrigin setting to false; which seems to be a reasonable workaround in the interim if windows users would like to take the extension for a spin.

@felipecaputo
Copy link
Owner

Hi @DamonOehlman, thanks for the PR! I'll take a look too in a way to find git and allow the check remote origin to work!

@felipecaputo felipecaputo merged commit 949b426 into felipecaputo:master Jun 14, 2017
@DamonOehlman DamonOehlman deleted the damon-windows-homepath branch June 16, 2017 06:42
@DamonOehlman
Copy link
Contributor Author

@felipecaputo Thanks - best project manager for code IMO - nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants