Files with classes that declare itself to be it's parent can cause an infinite loop when indexing.

[d0x2f]

I noticed this happening often when a project had phan installed as a dependency.

As a minimal example, the server will enter an infinite loop trying to index this file:

<?php
class C extends C {}
$c = new C;
$c->undef_prop = 1;

PR to follow.

[tomterl]

I'm curious: The example code throws Fatal Errors with php7.2 and php7.3; I agree that it shouldn't cause infinite loops in a parser/language-server -- why such code would be written alludes me! Would you care/be so kind to elaborate?

[felixfbecker]

There is no reason. But it shouldn’t cause infinite loops

[d0x2f]

@tomterl In my case, a project I'm working on uses a dev dependency (phan) that includes code that's deliberately written to trigger an error among it's tests.

Furthermore, simply typing an error like this by mistake is plausible, especially given that VSCode and this extension supports live feedback as you type.

[felixfbecker]

@d0x2f you might wanna suggest to Phan to not ship tests in their package

[tomterl]

Now that I'm thinking about it, during typing this might easily occur (class C extends CBase...)

[felixfbecker]

🎉 This issue has been resolved in version 5.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀