Variable symbols

[lgabeskiria]

We should exclude variable symbols that are defined in function and method body.

[codecov-io]

Current coverage is 89.94% (diff: 100%)

Merging #15 into master will increase coverage by 0.38%

@@             master        #15   diff @@
==========================================
  Files            14         14          
  Lines           182        189     +7   
  Methods          29         30     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            163        170     +7   
  Misses           19         19          
  Partials          0          0          

Diff Coverage	File Path
•••••••••• 100%	src/SymbolFinder.php

Powered by Codecov. Last update 7138088...1502c8b

[felixfbecker]

Should we? I remember that TypeScript language server once behaved that way, and they changed the behavior: microsoft/TypeScript#8218

[lgabeskiria]

I have latest version of typescript and it does not show symbols inside functions.

From my point of view it's better to hide symbols inside functions.
You can open some big php file and you'll see that it's quite uncomfortable to navigate to other method in class when you have variable symbols.

[lgabeskiria]

Alternatively we can add option to enable/disable this behavior.

[felixfbecker]

I double checked and you are right, we should follow TS' behavior here. A setting may be nice for a future update, but low priority.

[felixfbecker]

Could you rebase this on master (so it only includes the actual code changes)?

[lgabeskiria]

yes.

[felixfbecker]

To prevent this in the future, do you have a recommendation for #12 ?

[lgabeskiria]

I was unable to rebase the branch so I created another pull request #16 .
you can close this one.