Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(completion): don't require constructor parameter for protocol DTO #592

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

felixfbecker
Copy link
Owner

Should fix the error in atom/ide-php#47 (comment)

@felixfbecker felixfbecker merged commit d9bc0b0 into master Feb 2, 2018
@felixfbecker felixfbecker deleted the no-required-constructor-param branch February 2, 2018 20:09
@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #592 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #592   +/-   ##
=========================================
  Coverage     81.63%   81.63%           
  Complexity      910      910           
=========================================
  Files            61       61           
  Lines          2075     2075           
=========================================
  Hits           1694     1694           
  Misses          381      381
Impacted Files Coverage Δ Complexity Δ
src/Protocol/CompletionContext.php 100% <100%> (ø) 1 <1> (ø) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant