Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS package #579

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

DennisSnijder
Copy link
Contributor

@DennisSnijder DennisSnijder commented Jun 12, 2023

Context

As discussed in #303, I created a new package called nestjs-bull-board to easily integrate bull-board with NestJS. After some back and forth between @felixmosh and me, the library reached a state where it can be integrated into the bull-board mono-repo 😄

What has been done

Todo

  • Update the index README.md to mention the NestJS package.
  • Add a with-nestjs-module example to use the new module.

@DennisSnijder
Copy link
Contributor Author

@felixmosh what do you think about the documentation location? I kept it at the README.md in the package, should we keep it there or move it over to the main README.md? 🤔

@felixmosh
Copy link
Owner

felixmosh commented Jun 12, 2023

@felixmosh what do you think about the documentation location? I kept it at the README.md in the package, should we keep it there or move it over to the main README.md? 🤔

We can add a link to the main README, to the internal README...

Regarding the PR, let's add another example and call it with-nestjs-module (or something like this)

@DennisSnijder
Copy link
Contributor Author

@felixmosh what do you think about the documentation location? I kept it at the README.md in the package, should we keep it there or move it over to the main README.md? 🤔

We can add a link to the main README, to the internal README...

Alright! i'll do that!

@felixmosh felixmosh added the enhancement New feature or request label Jun 12, 2023
@DennisSnijder DennisSnijder changed the title [WIP] NestJS package NestJS package Jun 12, 2023
@DennisSnijder
Copy link
Contributor Author

@felixmosh ready for review 😄

When testing out the example, it depends on @bull-board/nestjs which isn't published yet, so the example might be broken until the package has been published to NPM.

@felixmosh felixmosh merged commit 60d7660 into felixmosh:master Jun 13, 2023
@felixmosh
Copy link
Owner

felixmosh commented Jun 13, 2023

Thank you for your contribution 🙏🏼

Published in v5.3.1

@felixmosh
Copy link
Owner

Can you prepare PR with the example? (don't forget to change the link in the README)

@DennisSnijder
Copy link
Contributor Author

DennisSnijder commented Jun 13, 2023

Can you prepare PR with the example? (don't forget to change the link in the README)

The example is already in there! I'll test it out / update it where needed + already added a link to the Readme 😄

edit: Preparing a new PR now 😄

@felixmosh
Copy link
Owner

I've updated the readme link, it was pointing to the old example

@DennisSnijder
Copy link
Contributor Author

Sweet! @felixmosh thanks for the help on making this part of the bull-board repository! 🥳

@felixmosh
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants