Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow nestjs v11 #880

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

snigdha920
Copy link
Contributor

Fixes the following issue in BullBoardModule.forFeature:

Type 'DynamicModule' is not assignable to type 'Type<any> | DynamicModule | Promise<DynamicModule> | ForwardReference<any>'.
  Type 'import("/Users/snigdhasingh/Development/btp/node_modules/@mikro-orm/nestjs/node_modules/@nestjs/common/interfaces/modules/dynamic-module.interface").DynamicModule' is not assignable to type 'import("/Users/snigdhasingh/Development/btp/node_modules/@nestjs/common/interfaces/modules/dynamic-module.interface").DynamicModule'.
    Types of property 'imports' are incompatible.
      Type '(DynamicModule | Type<any> | Promise<DynamicModule> | ForwardReference<any>)[] | undefined' is not assignable to type '(Type<any> | DynamicModule | Promise<DynamicModule> | ForwardReference<any>)[] | undefined'.
        Type '(DynamicModule | Type<any> | Promise<DynamicModule> | ForwardReference<any>)[]' is not assignable to type '(Type<any> | DynamicModule | Promise<DynamicModule> | ForwardReference<any>)[]'.
          Type 'DynamicModule | Type<any> | Promise<DynamicModule> | ForwardReference<any>' is not assignable to type 'Type<any> | DynamicModule | Promise<DynamicModule> | ForwardReference<any>'.
            Type 'Promise<DynamicModule>' is not assignable to type 'Type<any> | DynamicModule | Promise<DynamicModule> | ForwardReference<any>'.

@felixmosh
Copy link
Owner

Hi, thank you for your contribution.
Did u tested this PR?

@snigdha920
Copy link
Contributor Author

Hi! yes I did, it works. For context, here's a fix for the exact same issue in nestjs-prometheus: willsoto/nestjs-prometheus#2392

@felixmosh felixmosh merged commit b51fd8b into felixmosh:master Jan 20, 2025
@felixmosh
Copy link
Owner

Thank you, this fix is released available @ v6.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants