addpkg: diskonaut #1194
Merged
addpkg: diskonaut #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fix three error: 1. The [target specification issue]. 2. Crate libc can not be compiled due to symbol missing. This is fixed in [rust-lang/libc PR felixonmars#2668], and release in 0.2.118 version. 3. Test failure Some tests of diskonaut depend on the previous events. It take a snapshot of the TUI pixels output, then compare those snapshot pixel by pixel to determine if the cli is working correctly. However those test are not reliable. If the previous event took too long to finish, the TUI output will not match what is expected. The current workaround is to increase the event interval. One second interval is enough for all event to finish its jobs. Tested in 5950x QEMU environment. Ref: * [target specification issue]: felixonmars#670 (comment) * [rust-lang/libc PR felixonmars#2668]: rust-lang/libc#2668 Signed-off-by: Avimitin <avimitin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix three error:
The target specification issue.
Crate libc can not be compiled due to symbol missing.
This is fixed in rust-lang/libc PR #2668, and release in 0.2.118
version.
Test failure
Some tests of diskonaut depend on the previous events. It take a snapshot of the TUI pixels output, then compare those snapshot pixel by pixel to determine if the cli is working correctly. However those test are not reliable. If the previous event took too long to finish, the TUI output will not match what is expected. The current workaround is to increase the event interval. One second interval is enough for all event to finish its jobs.
Tested in 5950x QEMU environment.