Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting burst limit reached when it was not #7

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

p7g
Copy link
Collaborator

@p7g p7g commented Mar 29, 2022

Not sure what the exact intent was with the old code, but it seems like it was reporting that the burst limit was reached every time the pool stopped bursting 🤔

After these changes it should work as expected, and it will only create the event once per time the pool is bursting.

@p7g p7g requested review from sciyoshi, ericls and miadabrin March 29, 2022 16:09
@coveralls
Copy link

coveralls commented Mar 29, 2022

Coverage Status

Coverage increased (+1.006%) to 87.736% when pulling 5d0f16c on false-positive-burst-limit-reached into 5a5405b on main.

@p7g p7g merged commit 7d7b011 into main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants