Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build fails with mlir 18.1.6 #45

Open
jerielverissimo opened this issue Jul 27, 2024 · 0 comments · May be fixed by #46
Open

build fails with mlir 18.1.6 #45

jerielverissimo opened this issue Jul 27, 2024 · 0 comments · May be fixed by #46

Comments

@jerielverissimo
Copy link

Hi folks, I'm trying to build this lib on my environment (ArchLinux) with LLVM 18 installed: 18.1.8
but I'm facing the following error:

error: library name must not be empty

error: could not compile `mlir-sys` (lib) due to 1 previous error
DaniPopes added a commit to DaniPopes/mlir-sys that referenced this issue Aug 7, 2024
@DaniPopes
Correctly propagate llvm-config errors
3c2a273 
Currently, due to the extra `sh`/`cmd` indirection, if the `llvm-config` fails
in the middle of the build script (say in `--libnames`), it will emit an empty
`rustc-link-lib` name because the error is not propagated. The error is also not
shown, and cargo will fail with a mysterious "library name must not be empty".

Remove this extra indirection and improve the error messages by showing the full
context if this happens.

Fixes femtomc#45
@DaniPopes DaniPopes linked a pull request Aug 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly propagate llvm-config errors DaniPopes/mlir-sys
1 participant
@jerielverissimo