-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add rounded
option to the getCroppedCanvas
method (#551)
#1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7anshuai
force-pushed
the
fix/1px-black-line
branch
2 times, most recently
from
March 1, 2023 08:21
044a7f1
to
c2946c5
Compare
7anshuai
changed the title
fix: add
fix: add Mar 14, 2023
rounded
option to getCroppedCanvas
method (#551)rounded
option to the getCroppedCanvas
method (#551)
gtteamamxx
reviewed
Jul 27, 2023
src/js/methods.js
Outdated
@@ -654,7 +654,7 @@ export default { | |||
y: initialY, | |||
width: initialWidth, | |||
height: initialHeight, | |||
} = this.getData(); | |||
} = this.getData(options.rounded || false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!options.rounded
gtteamamxx
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7anshuai
force-pushed
the
fix/1px-black-line
branch
from
July 27, 2023 08:36
c2946c5
to
68e80ee
Compare
This was referenced May 20, 2024
This was referenced May 27, 2024
This was referenced Jun 3, 2024
This was referenced Aug 25, 2024
This was referenced Sep 2, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: