Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep back compatibility #799

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix: keep back compatibility #799

merged 1 commit into from
Feb 17, 2021

Conversation

septs
Copy link
Contributor

@septs septs commented Feb 16, 2021

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

see #791 (comment)

@septs
Copy link
Contributor Author

septs commented Feb 16, 2021

CC @muk-ai

@muk-ai
Copy link

muk-ai commented Feb 17, 2021

Thanks for the change 👍
Our code no longer causes compilation errors.

@fengyuanchen fengyuanchen merged commit 5a81449 into fengyuanchen:master Feb 17, 2021
fengyuanchen pushed a commit that referenced this pull request Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants