♻️ refactor!: replace PDM, pipx, pyenv and more with uv #1
Conversation
fepegar
changed the title
| @@ -11,7 +11,6 @@ ENV HOROVOD_GPU_ALLREDUCE=NCCL | |||
|
|
|||
| RUN apt-get -qq update \ | |||
| && apt-get -qq install --no-install-recommends \ | |||
| python3-minimal python3-dev python3-pip python3-venv python-is-python3 pipx \ | |||
There was a problem hiding this comment.
Are they needed? uv should be able to manage Python, venvs and tools installation (pipx -> uv tool install).
| sed -i 's/plugins=(git)/plugins=(git pdm)/' ~/.zshrc | ||
| pdm config virtualenvs.in-project true | ||
| echo "UV INSTALL" | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh |
There was a problem hiding this comment.
Running unsigned scripts is insecure should not be used in prod environments, why not install with pipx? That's why I install python in the base image and pipx...
There was a problem hiding this comment.
That URL redirects to https://github.com/astral-sh/uv/releases/latest/download/uv-installer.sh, which simply downloads the binaries (uv and uvx) from the latest release, for the target platform. We could do that ourselves, without the script.
Another option is simply
COPY --from=ghcr.io/astral-sh/uv:latest /uv /usr/local/bin/uv| @@ -12,8 +12,7 @@ git config --global alias.mt mergetool | |||
| git config --global alias.pl pull --rebase | |||
|
|
|||
| echo "INSTALLING COMMITIZEN" | |||
| pipx install commitizen | |||
| pipx inject commitizen cz-conventional-gitmoji | |||
| uv tool install --with cz-conventional-gitmoji commitizen | |||
There was a problem hiding this comment.
needs changing if we install with pipx. Let's agree first.
| @@ -22,5 +21,4 @@ if [ ! -d .git ]; then | |||
| echo "Initializing Git..." | |||
| git init | |||
| fi | |||
| pipx install pre-commit | |||
| pre-commit install --install-hooks | |||
| uvx --with pre-commit-uv -- pre-commit install --install-hooks | |||
There was a problem hiding this comment.
See #1 (comment).
We're saying "install x and also pre-commit-uv in a temporary environment, and run x args, where x is pre-commit and args is install --install-hooks.
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 |
There was a problem hiding this comment.
not a fan of untrusted github actions, can you use these in enterprise github?
There was a problem hiding this comment.
I'm not sure what you mean. Is there a list of trusted actions? I think it would work.
|
|
||
| The only required dependency is [uv](https://docs.astral.sh/uv/getting-started/installation/). |
There was a problem hiding this comment.
I do like that uv installs python if required, this is nice.
There was a problem hiding this comment.
Yes! Also they've just taken over python-build-standalone themselves.
There was a problem hiding this comment.
(which is where uv downloads Python from)
| @@ -1,27 +1,27 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| echo "RUNNING PRE-COMMIT HOOKS" | |||
| pre-commit run --all | |||
| uvx -- pre-commit run --all | |||
There was a problem hiding this comment.
what's the difference between uvx and uv run?
There was a problem hiding this comment.
I think uv run thing is a bit like doing this:
uv python install # ensure Python is installed (latest specified in pyproject.toml, or the one pinned in .python-version
uv lock # ensure the lock file is in sync with pyproject.toml
uv sync # ensure the venv exists and is in sync with the lock file
source .venv/bin/activate
thing
deactivateuvx is the same as uv tool run. uv tool run thing would be something like:
uv venv /tmp/some_dir/.venv # uses the latest installed Python
cd /tmp/some_dir
uv add thing
source .venv/bin/activate
thing
deactivate
Not exactly what goes on, but hopefully that helps. In this case, thing is the name of the entry script and the package. Otherwise you'd do something like uv tool run --from my_package my_command. The dashes -- are not needed, by I think they make things more readable sometimes.
If a tool is installed (with uv tool install), uv tool run (or uvx) will use the installed version.
Replace multiple tools with
uvfor a more streamlined experience.