-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deeplink to service #1344
Conversation
Very nice if this works @SpecialAro ! |
I've tested on my macOS (had to build the app to test, as ferdium-dev protocol was opening an Electron window that was not ferdium) but it worked! The downside is having to call the serviceId and not the name of a service 🥲 but in the future maybe we can improve this with a better logic |
This looks really interesting. Can you give us some use-cases and examples for a more clear picture and various scenarios? |
@KrystianLesniak Thanks for trying it. As mentioned by @SpecialAro above:
this means that you would need to call the url with the full serviceId, which is something that looks like |
Got it! I've referenced to "id" from these documents: That's why I misunderstood what "id" property is. I will try it later, thanks! |
Hey! Thank you @Alphrag for clarifying! That is indeed what I meant. Nevertheless, I'll try to implement the |
Indeed does documents refer to a Recipe Id (which would be used in the approach that I just written). I'll try to make a simple approach that activates the first service and then we can think of improving it. |
I've quickly tested with correct service Id exported from .ferdium-data file and unfortunately the same issues as mentioned above happens. So it's just launching application without changing to correct service or blank purple screen when application is already launched. |
I just noticed a bug. You are using Windows, am I right? I bet @Alphrag used macOS (as I did when coding - but now just tested with windows) basically windows is adding a string with "--allow-file-access-from-files" for some reason... causing it to crash: |
Yes, bug occurs at Windows 11 x64. Great and quick bug source finding @SpecialAro ! |
Yeah I've tested it on mac, and doing something like |
This reverts commit 970738c.
add deeplink to service
Hello everyone. |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Enables activating a service by using
ferdium://service/:serviceId
Motivation and Context
This PR fixes #1243. In the future, It would be interesting to also handle
ferdium://service/:serviceName
and present the user with different options if there is more than one recipe with the same nameChecklist
pnpm prepare-code
)pnpm test
passesRelease Notes
notes: Added feature for activating a service from deep link using the service
id
.